0005993: class rhs_weap_mg42_base bad firemode naming

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005993

GREF

[All Projects] General

public

2020-11-02 10:31

2020-11-02 11:11

Reporter

dock97kf

Assigned To

reyhard

Priority

none

Severity

tweak

Reproducibility

always

Status

closed

Resolution

won't fix

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0005993: class rhs_weap_mg42_base bad firemode naming

Description

In every RHS weapon base firemode class has name "FullAuto" or "Single", in class rhs_weap_mg42_base it is "manual". This is not good for addon making.

Steps To Reproduce

@RHSGREF\addons\rhsgref_c_weapons\config.cpp:
6989: modes[] = {"manual", "close", "short", "medium", "far"};
    class manual : Mode_FullAuto {
        reloadTime = 0.05;
        dispersion = 0.0008;
        soundContinuous = 0;
        soundBurst = 0;
        minRange = 0;
        minRangeProbab = 0.3;
        midRange = 5;
        midRangeProbab = 0.58;
        maxRange = 10;
        maxRangeProbab = 0.04;
        showToPlayer = true;
    };
    class close : manual {
        burst = 8;
        burstRangeMax = 12;
        aiRateOfFire = 0.5;
        aiRateOfFireDistance = 50;
        minRange = 10;
        minRangeProbab = 0.05;
        midRange = 20;
        midRangeProbab = 0.58;
        maxRange = 50;
        maxRangeProbab = 0.04;
        showToPlayer = false;
        aiBurstTerminable = 1;
    };

Additional Information

Shoud be:
@RHSGREF\addons\rhsgref_c_weapons\config.cpp:
6989: modes[] = {"FullAuto", "close", "short", "medium", "far"};
    class FullAuto: Mode_FullAuto {
        reloadTime = 0.05;
        dispersion = 0.0008;
        soundContinuous = 0;
        soundBurst = 0;
        minRange = 0;
        minRangeProbab = 0.3;
        midRange = 5;
        midRangeProbab = 0.58;
        maxRange = 10;
        maxRangeProbab = 0.04;
        showToPlayer = true;
    };
    class close : FullAuto{
        burst = 8;
        burstRangeMax = 12;
        aiRateOfFire = 0.5;
        aiRateOfFireDistance = 50;
        minRange = 10;
        minRangeProbab = 0.05;
        midRange = 20;
        midRangeProbab = 0.58;
        maxRange = 50;
        maxRangeProbab = 0.04;
        showToPlayer = false;
        aiBurstTerminable = 1;
    };

Tags

No tags attached.

RHS version

Stable

Attached Files

Relationships

Notes
(0011209) reyhard (administrator) 2020-11-02 10:39	It doesn't matter at all for engine how it's named - is there some problem with that for you?

(0011210) dock97kf (reporter) 2020-11-02 10:46	Yes, I'm creating an addon (Some AI behavior tweaks) and using python scripts to generate configs - don't want to create an exception for only one weapon.

(0011211) reyhard (administrator) 2020-11-02 11:11	I'm sorry but if it's not causing any factual errors I'm afraid I will keep it this way - mainly due to backward compatibility and all mods which are using current syntax.

Issue History
Date Modified	Username	Field	Change
2020-11-02 10:31	dock97kf	New Issue
2020-11-02 10:34	dock97kf	Steps to Reproduce Updated	View Revisions
2020-11-02 10:34	dock97kf	Additional Information Updated	View Revisions
2020-11-02 10:39	reyhard	Note Added: 0011209
2020-11-02 10:39	reyhard	Assigned To	=> reyhard
2020-11-02 10:39	reyhard	Status	new => feedback
2020-11-02 10:46	dock97kf	Note Added: 0011210
2020-11-02 10:46	dock97kf	Status	feedback => new
2020-11-02 11:11	reyhard	Note Added: 0011211
2020-11-02 11:11	reyhard	Status	new => closed
2020-11-02 11:11	reyhard	Resolution	open => won't fix