RHS Feedback - GREF
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0005993GREF[All Projects] Generalpublic2020-11-02 10:312020-11-02 11:11
Reporterdock97kf 
Assigned Toreyhard 
PrioritynoneSeveritytweakReproducibilityalways
StatusclosedResolutionwon't fix 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
RHS versionStable
Summary0005993: class rhs_weap_mg42_base bad firemode naming
DescriptionIn every RHS weapon base firemode class has name "FullAuto" or "Single", in class rhs_weap_mg42_base it is "manual". This is not good for addon making.
Steps To Reproduce@RHSGREF\addons\rhsgref_c_weapons\config.cpp:
6989: modes[] = {"manual", "close", "short", "medium", "far"};
    class manual : Mode_FullAuto {
        reloadTime = 0.05;
        dispersion = 0.0008;
        soundContinuous = 0;
        soundBurst = 0;
        minRange = 0;
        minRangeProbab = 0.3;
        midRange = 5;
        midRangeProbab = 0.58;
        maxRange = 10;
        maxRangeProbab = 0.04;
        showToPlayer = true;
    };
    class close : manual {
        burst = 8;
        burstRangeMax = 12;
        aiRateOfFire = 0.5;
        aiRateOfFireDistance = 50;
        minRange = 10;
        minRangeProbab = 0.05;
        midRange = 20;
        midRangeProbab = 0.58;
        maxRange = 50;
        maxRangeProbab = 0.04;
        showToPlayer = false;
        aiBurstTerminable = 1;
    };
Additional InformationShoud be:
@RHSGREF\addons\rhsgref_c_weapons\config.cpp:
6989: modes[] = {"FullAuto", "close", "short", "medium", "far"};
    class FullAuto: Mode_FullAuto {
        reloadTime = 0.05;
        dispersion = 0.0008;
        soundContinuous = 0;
        soundBurst = 0;
        minRange = 0;
        minRangeProbab = 0.3;
        midRange = 5;
        midRangeProbab = 0.58;
        maxRange = 10;
        maxRangeProbab = 0.04;
        showToPlayer = true;
    };
    class close : FullAuto{
        burst = 8;
        burstRangeMax = 12;
        aiRateOfFire = 0.5;
        aiRateOfFireDistance = 50;
        minRange = 10;
        minRangeProbab = 0.05;
        midRange = 20;
        midRangeProbab = 0.58;
        maxRange = 50;
        maxRangeProbab = 0.04;
        showToPlayer = false;
        aiBurstTerminable = 1;
    };
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-11-02 10:31dock97kfNew Issue
2020-11-02 10:34dock97kfSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7096#r7096
2020-11-02 10:34dock97kfAdditional Information Updatedbug_revision_view_page.php?rev_id=7098#r7098
2020-11-02 10:39reyhardNote Added: 0011209
2020-11-02 10:39reyhardAssigned To => reyhard
2020-11-02 10:39reyhardStatusnew => feedback
2020-11-02 10:46dock97kfNote Added: 0011210
2020-11-02 10:46dock97kfStatusfeedback => new
2020-11-02 11:11reyhardNote Added: 0011211
2020-11-02 11:11reyhardStatusnew => closed
2020-11-02 11:11reyhardResolutionopen => won't fix

Notes
(0011209)
reyhard   
2020-11-02 10:39   
It doesn't matter at all for engine how it's named - is there some problem with that for you?
(0011210)
dock97kf   
2020-11-02 10:46   
Yes, I'm creating an addon (Some AI behavior tweaks) and using python scripts to generate configs - don't want to create an exception for only one weapon.
(0011211)
reyhard   
2020-11-02 11:11   
I'm sorry but if it's not causing any factual errors I'm afraid I will keep it this way - mainly due to backward compatibility and all mods which are using current syntax.