RHS Feedback - AFRF
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003809AFRF[All Projects] Generalpublic2017-11-20 23:342017-11-22 23:47
ReporterMorluck 
Assigned Toreyhard 
PrioritynoneSeverityminorReproducibilityalways
StatusclosedResolutionsuspended 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Is it a wish/request?No
RHS version
Arma 3 version1.76
Did you used any other mod when the error occurred?Yes
Which mods?ACRE
Summary0003809: ACRE compatibility issue for BMP1s and BMP2s, fix included.
DescriptionThe commander's seat for all variants the of BMP1s and BMP2s is not properly defined for ACRE vehicle rack support.

To Fix:
Change primaryObserver=0; to primaryObserver=1; under hs_bmp1tank_base and rhs_bmp2e_vdv commander's section.
Change primaryObserver=1; to primaryObserver=0; under rhs_bmp1p_vdv launcher section.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-20 23:34MorluckNew Issue
2017-11-21 08:40reyhardNote Added: 0007086
2017-11-21 08:40reyhardStatusnew => closed
2017-11-21 08:40reyhardAssigned To => reyhard
2017-11-21 08:40reyhardResolutionopen => suspended
2017-11-21 22:10MorluckNote Added: 0007094
2017-11-22 09:56reyhardNote Added: 0007097
2017-11-22 09:58reyhardNote Edited: 0007097bug_revision_view_page.php?bugnote_id=7097#r4837
2017-11-22 23:47MorluckNote Added: 0007109

Notes
(0007086)
reyhard   
2017-11-21 08:40   
primaryObserver=0 for commander will break unit placement in 3den - units will spawn with driver & commander only. There was fix on devbranch some time ago but I'm not sure if it's going to land in Tacops DLC
(0007094)
Morluck   
2017-11-21 22:10   
My apologies for not being explaining the changes.
Change primaryObserver=0; to primaryObserver=1; under hs_bmp1tank_base and rhs_bmp2e_vdv commander's section.
The commander for BMP1s and BMP2s is currently primaryObserver=0, please change it to primaryObserver=1.

The ATGM for BMP1Ps is currently primaryObserver=1, please change it to primaryObserver=0. Otherwise, the ATGM for the BMP1P is defined as the seat for the commander instead of the actual commander's seat.

If only the first change is made all BMP1s and BMP2s will have compatibility with ACRE fixed with the exception of the BMP1P due to the ATGM inheriting the commander, hence the necessity of setting that seat to 0.
(0007097)
reyhard   
2017-11-22 09:56   
(edited on: 2017-11-22 09:58)
I checked configs and ATGM have already primaryObserver = 0;


    class rhs_bmp1p_vdv : rhs_bmp1_vdv
    {
        EdPrev(rhs_bmp1p_vdv)

        model = "\rhsafrf\addons\rhs_bmp\BMP1p.p3d";
        picture = "\rhsafrf\addons\rhs_bmp\pictures\rhs_bmp1p_pic_ca.paa";
        Author_Macro
        displayName= $STR_BMP1P_Name;
        forceIngarage=0;

        class Turrets : Turrets
        {
            class MainTurret : MainTurret
            {
                weapons[] = {"rhs_weap_2a28", "rhs_weap_pkt","rhs_weap_902a"};
                magazines[] = {"rhs_mag_og15v_20","rhs_mag_pg15v_20","rhs_mag_762x54mm_250","rhs_mag_762x54mm_250","rhs_mag_762x54mm_250","rhs_mag_762x54mm_250","rhs_mag_762x54mm_250","rhs_mag_762x54mm_250","rhs_mag_762x54mm_250","rhs_mag_762x54mm_250","rhs_mag_3d17_6"};

                LODTurnedIn =1200;
                class Turrets: Turrets
                {
                    class Launcher: CommanderOptics
                    {
                        gunnername = "9P135 Launcher";

                        proxyType = "CPGunner";
                        primaryObserver = 0;

are you using some 3rd party mods or is it with some particular variant?

as for commander, I made that change on purpose due to above mentioned bug
(0007109)
Morluck   
2017-11-22 23:47   
The mods I was using for the test were RHS and ACRE from the Steam Workshop.
As for the BMP1p, I think I made mistake on my end when investigating the incompatibility issue; looking at it again it is currently primaryObserver = 0 in the current version of RHS as you say.
For the other BMPs, recreating my test with the fix I suggested, I'm also seeing the commander issue that you pointed out that I missed the first time. Hopefully, the bugfix is pushed by the arma devs soon, until then guess we'll just have to wait.