RHS Feedback - USAF
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001453USAF[All Projects] Generalpublic2015-12-09 02:232016-11-22 10:52
Reporterrogerx 
Assigned ToSoul_Assassin 
PrioritynoneSeverityminorReproducibilityalways
StatusclosedResolutionwon't fix 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Is it a wish/request?No
RHS version
Arma 3 version1.54
Did you used any other mod when the error occurred?No
Which mods?
Summary0001453: wget should use "--continue"!
Description

FILE: update_rhsusf.bat

-- wget -m -nH --cut-dirs=2 --retry-connrefused --timeout=30 ftp://ftp.rhsmods.org/beta/rhsusaf/ [^]

++ wget --continue --cut-dirs=2 --mirror --no-host-directories --retry-connrefused --timeout=30 ftp://ftp.rhsmods.org/beta/rhsusaf/ [^]

1) Added "--continue" parameter. (For obvious reasons, stopping a download should not have to revert to downloading for the first byte! Reduces server loads.)

2) I also switched "-nH" short option for the long option "--no-host-directories". The same with "-m", the long option being "--mirror". A underlying rule for short/long options, use the short options when typing via command line for less typing, and the long options for use within script files for easier reading.

3) Alphabetized wget's used parameters.

Implementation of "--continue" should likely be the priority, versus the other changes which are basically cosmetic, but dictate good coding style. ;-)
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-12-09 02:23rogerxNew Issue
2015-12-09 08:19RedPhoenixAssigned To => Soul_Assassin
2015-12-09 11:15Soul_AssassinNote Added: 0002987
2015-12-09 11:15Soul_AssassinStatusnew => acknowledged
2016-11-22 10:52Soul_AssassinNote Added: 0005551
2016-11-22 10:52Soul_AssassinStatusacknowledged => closed
2016-11-22 10:52Soul_AssassinResolutionopen => won't fix

Notes
(0002987)
Soul_Assassin   
2015-12-09 11:15   
Thanks for the input. Some feedback:

1. It was actually initially there, however for some reason it did not work with the pbos, and they became corrupted, and thus this was removed.

2. While I agree about style changes it does not warrant right now for immediate update.

With that being said I leave this task on "Acknowledged" as I think these comments are valid. I had in mind already for a while a more advanced updater (same background wget tech but nicer interface/feedback). When I get around to it I will keep these things in mind.
(0005551)
Soul_Assassin   
2016-11-22 10:52   
In light of full move to SW, this is irrelevant.